Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Workflow execution conditions did not execute as expected #1915

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

shaohuzhang1
Copy link
Contributor

fix: Workflow execution conditions did not execute as expected

Copy link

f2c-ci-robot bot commented Dec 26, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

f2c-ci-robot bot commented Dec 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -679,7 +679,7 @@ def get_next_node_list(self, current_node, current_node_result):
self.get_node_cls_by_id(edge.targetNodeId, self.get_up_node_id_list(edge.targetNodeId)))
else:
node_list.append(
self.get_node_cls_by_id(edge.targetNodeId, self.get_up_node_id_list(edge.targetNodeId)))
self.get_node_cls_by_id(edge.targetNodeId, [current_node.node.id]))
return node_list

def get_reference_field(self, node_id: str, fields: List[str]):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code has a few potential improvements to enhance clarity and maintainability:

  1. Remove the empty list as an argument when calling self.get_node_cls_by_id. This is redundant since it's implied that there should be at least one element in the list.

Here's the revised code:

@@ -679,8 +679,8 @@ def get_next_node_list(self, current_node, current_node_result):
                             self.get_node_cls_by_id(edge.targetNodeId,
                                                    self.get_up_node_id_list(edge.targetNodeId))).append(node)
                     else:
                         node_list.extend([self.get_node_cls_by_id(edge.targetNodeId,
                                                                  [current_node.node.id])])
         return node_list

     def get_reference_field(self, node_id: str, fields: List[str]):

This change ensures that the function call to self.get_node_cls_by_id includes all necessary parameters without unnecessary redundancy.

@shaohuzhang1 shaohuzhang1 merged commit d9dcd33 into main Dec 26, 2024
4 of 5 checks passed
@shaohuzhang1 shaohuzhang1 deleted the pr@main@fix_workflow_conditions branch December 26, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant