Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Workflow execution conditions did not execute as expected #1915

Merged
merged 1 commit into from
Dec 26, 2024
Merged

fix: Workflow execution conditions did not execute as expected #1915

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/application/flow/workflow_manage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,7 @@ def get_next_node_list(self, current_node, current_node_result):
self.get_node_cls_by_id(edge.targetNodeId, self.get_up_node_id_list(edge.targetNodeId)))
else:
node_list.append(
self.get_node_cls_by_id(edge.targetNodeId, self.get_up_node_id_list(edge.targetNodeId)))
self.get_node_cls_by_id(edge.targetNodeId, [current_node.node.id]))
return node_list

def get_reference_field(self, node_id: str, fields: List[str]):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code has a few potential improvements to enhance clarity and maintainability:

  1. Remove the empty list as an argument when calling self.get_node_cls_by_id. This is redundant since it's implied that there should be at least one element in the list.

Here's the revised code:

@@ -679,8 +679,8 @@ def get_next_node_list(self, current_node, current_node_result):
                             self.get_node_cls_by_id(edge.targetNodeId,
                                                    self.get_up_node_id_list(edge.targetNodeId))).append(node)
                     else:
                         node_list.extend([self.get_node_cls_by_id(edge.targetNodeId,
                                                                  [current_node.node.id])])
         return node_list

     def get_reference_field(self, node_id: str, fields: List[str]):

This change ensures that the function call to self.get_node_cls_by_id includes all necessary parameters without unnecessary redundancy.

Expand Down
Loading