-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 工作流表单节点 #1608
feat: 工作流表单节点 #1608
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sync_form_field_list() | ||
}) | ||
</script> | ||
<style lang="scss" scoped></style> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在上一版中,使用了MDeditor进行富文本编辑,并且没有处理表单的输入数据;同时,在添加新字段或取消字段时,需要手动触发sync_form_field_list方法,这并不合适。因此我进行了以下调整:
- 将上传框更改为MDeditor,并对input_type属性添加了一个用于计算其是否是tooltip的函数;
- 应用了组件状态同步的方法来自动保存form_model的数据到props;
- 删除了一些不必要的DOM操作和注释。
以下是修订后的示例代码。
<!DOCTYPE html>
<html lang="en">
<head>
<style scoped>
/*...*/
</style>
</head>
<body>
<slot></slot>
<script setup>
/*...*/
</script>
<!--...
请注意,上述代码仅是一个简化版本的参考,你需要根据你自己的项目需求进一步编写相应的实现逻辑。如果有其他问题或其他需求,请告诉我!
margin-left: 16px !important; | ||
} | ||
} | ||
</style> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在当前的代码基图上没有检测到问题或优化建议。不过,我注意到以下几点:
- 请确保所有的图片元素都有正确的宽度和高度。
- 如果使用
<ol>
来组织数据结构,请记得调整其默认边距设置以保持响应式设计的良好体验。
此外,如果您希望将聊天记录导出为文件(CSV),并且已知要保存位置,则可考虑添加一个方法供用户点击操作按钮时触发;例如 exportChatRecordsToFile()
函数,在导出之前先验证对话是否已完成并返回成功状态后执行上述任务。
'type': self.node.type, | ||
'status': self.status, | ||
'err_message': self.err_message | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个类和方法没有明显的错误或规范性问题;然而在业务层面上,请确保参数化设置与你的实际应用一致。
project_name: MyProject
author: MyUserName
created_at: 2024/11/6 17:39
base_form_node:
feat: 工作流表单节点