Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复嵌入图片过大指引位置错误 #1802

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

shaohuzhang1
Copy link
Contributor

fix: 修复嵌入图片过大指引位置错误

Copy link

f2c-ci-robot bot commented Dec 10, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

f2c-ci-robot bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shaohuzhang1 shaohuzhang1 merged commit 672cb7d into main Dec 10, 2024
4 checks passed
@shaohuzhang1 shaohuzhang1 deleted the pr@main@fix_embed branch December 10, 2024 06:48
@@ -306,4 +317,4 @@ function embedChatbot() {
initMaxkb()
} else console.error('invalid parameter')
}
window.onload = embedChatbot
window.addEventListener('load',embedChatbot)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此段代码主要涉及初始化聊天控件的设置和事件处理,其中对文档流(viewport)元素有一定的引用,需要进一步明确是针对哪些窗口尺寸进行适配。

对于代码中存在的一些问题:1) 在处理拖动事件时使用 clientYclientX 计算距离而不是实际的位置;2) 使用绝对定位布局后应考虑在计算样式高度宽度以及鼠标悬停效果时引入相对单位(px),如:not(#maxkb .maxkb-mask)等条件用于获取或限制元素大小。这些调整有助于提升代码的可读性和实用性,避免了不必要的浏览器兼容性问题。

shaohuzhang1 added a commit that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant