Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The dropdown menu of workflow basic components cannot be scrolled #1946

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

shaohuzhang1
Copy link
Contributor

fix: The dropdown menu of workflow basic components cannot be scrolled

Copy link

f2c-ci-robot bot commented Dec 30, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

f2c-ci-robot bot commented Dec 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shaohuzhang1 shaohuzhang1 merged commit ad9c837 into main Dec 30, 2024
4 checks passed
@shaohuzhang1 shaohuzhang1 deleted the pr@main@fix_base_node_wheel branch December 30, 2024 06:22
@@ -394,7 +410,8 @@ const switchFileUpload = () => {
}

if (form_data.value.file_upload_enable) {
form_data.value.file_upload_setting = form_data.value.file_upload_setting || default_upload_setting
form_data.value.file_upload_setting =
form_data.value.file_upload_setting || default_upload_setting
}
props.nodeModel.graphModel.eventCenter.emit('refreshFileUploadConfig')
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code appears to be well-written and follows standard conventions for Vue.js 3 with TypeScript. However, there are a few minor points that could potentially enhance readability or maintainability:

  1. Empty Lines: The code contains empty lines after some @submitDialog calls without spaces around them. Adding spacing makes it easier to read.

  2. Spaces Around Operators: There are no spaces between the operators (=) in expressions like size="small" and v-model="form_data.file_upload_enable". Adding spaces improves readability.

  3. Comment Formatting: Comments are formatted consistently but could be more descriptive depending on their content.

Here is a slightly revised version of the template based on these suggestions:

<template>
  <!-- ... rest of the template unchanged... -->
</template>

<script setup lang="ts">
// ... rest of the script unchanged...
</script>

Summary of Optimization Suggested

  1. Add Spaces:
    • In JavaScript/TypeScript assignments within attributes (e.g., size="small", v-model="formData.file_upload_enabled").
    • Add spaces around assignment operators (=).

These adjustments can make the code more readable and consistent with industry standards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant