Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Typos #2014

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix: Typos #2014

merged 1 commit into from
Jan 13, 2025

Conversation

shaohuzhang1
Copy link
Contributor

fix: Typos

Copy link

f2c-ci-robot bot commented Jan 13, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

f2c-ci-robot bot commented Jan 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -334,7 +334,7 @@ const submit = async () => {
applicationApi
.updatePlatformConfig(id, configType.value, form[configType.value], loading)
.then(() => {
MsgSuccess(t('commom.saveSuccess'))
MsgSuccess(t('common.saveSuccess'))
closeDrawer()
emit('refresh')
})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided JavaScript code snippet looks mostly clean, but there's one potential issue that could be addressed:

Potential Issue:

The form object is missing from the parameter list for the applicationApi.updatePlatformConfig method call. This means that the correct property name used to access the form data might not match what is expected.

Optimization Suggestions:

  • Check Form Data Access: Ensure that the form object contains the necessary properties to update the platform configuration. If it doesn't, you may need to modify how the form data is accessed or passed to the API.

Here's the original text repeated for clarity:


Original Text Repeated

@@ -334,7 +334,7 @@
   const submit = async () => {
     applicationApi
       .updatePlatformConfig(id, configType.value, form[configType.value], loading)
       .then(() => {
-        MsgSuccess(t('commom.saveSuccess'))
+        MsgSuccess(t('common.saveSuccess'))
         closeDrawer()
         emit('refresh')
       })

@shaohuzhang1 shaohuzhang1 merged commit 2f01708 into main Jan 13, 2025
4 checks passed
@shaohuzhang1 shaohuzhang1 deleted the pr@main@fix_typos branch January 13, 2025 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant