Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add item state field and deprecate trashed field #30

Merged
merged 5 commits into from
Oct 20, 2021

Conversation

Marton6
Copy link
Member

@Marton6 Marton6 commented Sep 23, 2021

This PR adds the item State field which is received from Connect, and marks the trashed field as deprecated as it is no used.

Copy link
Member

@jpcoenen jpcoenen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing this 🙌

I have a few minor suggestions to simplify stuff. Let me know what you think.

onepassword/items.go Outdated Show resolved Hide resolved
onepassword/items.go Outdated Show resolved Hide resolved
onepassword/items.go Outdated Show resolved Hide resolved
@Marton6 Marton6 merged commit 6f85f06 into main Oct 20, 2021
@Marton6 Marton6 deleted the fix/add-item-state-field branch October 20, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants