This repository has been archived by the owner on Jun 21, 2024. It is now read-only.
Add support for simple SnmpSet operations. Add unit tests for it. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfuhrm
suggested changes
Jan 23, 2020
| @@ -144,8 +149,8 @@ public boolean next(final SubRequest request) { | |||
| @Override | |||
| public void prepare(SubRequest request) { | |||
| RequestStatus status = request.getStatus(); | |||
| if (request.getIndex() > 0) { | |||
| //Skip rowStatusColumn SubRequest with index 0 | |||
| if (isSimpleSetOperation(request) || request.getIndex() > 0) { | |||
There was a problem hiding this comment.
You're replacing every (request.getIndex() > 0) condition with a (isSimpleSetOperation(request) || request.getIndex() > 0) condition.
It would be shorter and easier to put all logic of the condition inside the isSimpleSetOperation() method and give it a good name.
| @@ -131,6 +132,10 @@ public boolean next(final SubRequest request) { | |||
| return false; | |||
| } | |||
|
|
|||
| private boolean isSimpleSetOperation(SubRequest request) { | |||
There was a problem hiding this comment.
if not accessing members, please make it static to show that :)
conflicts with Log4j2 API.
Already applied in master
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.