Обновление на новый парсер с antlr 4.13.1 #3266
Conversation
|
Warning Rate limit exceeded@theshadowco has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 16 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughВ этом обновлении были внесены изменения в зависимости и реализацию методов в проекте. Зависимости Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Qodana Community for JVM15 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
theshadowco
force-pushed
the
feature/bumpantlr
branch
from
c2ba04f to
0c111b6
Compare
|
github-actions
bot
force-pushed
the
feature/bumpantlr
branch
from
0c111b6 to
bc70d67
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- build.gradle.kts (2 hunks)
- src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/RewriteMethodParameterDiagnostic.java (3 hunks)
Additional comments not posted (4)
src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/RewriteMethodParameterDiagnostic.java (3)
38-38: Импорт классаParseTreeдобавлен в связи с обновлением парсера. Убедитесь, что он используется в коде.Verification successful
Импорт класса
ParseTreeдействительно используется в коде.
- Линии кода, где используется
ParseTree:
.map(ParseTree::getParent).map(ParseTree::getParent)Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Описание: Проверка использования класса ParseTree в коде. # Тест: Поиск использования класса ParseTree. Ожидаем: Наличие использования. rg --type java $'ParseTree' src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/RewriteMethodParameterDiagnostic.javaLength of output: 241
175-175: Изменение методаisVarNameOnlyIntoExpressionдля использованияParseTree. Убедитесь, что это изменение не влияет на существующую функциональность.
158-158: Обновление методаgetRefContextInsideDefAssignдля использованияParseTreeвместоRuleNode. Проверьте, что новый подход корректно интегрируется с остальной частью кода.Also applies to: 164-165
build.gradle.kts (1)
77-77: Обновление зависимостейbsl-parserиbsl-parser-core. Убедитесь, что новые версии совместимы с текущим проектом и не вызывают конфликтов.Also applies to: 87-87
theshadowco
force-pushed
the
feature/bumpantlr
branch
from
bc70d67 to
78f6110
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- build.gradle.kts (2 hunks)
- src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/RewriteMethodParameterDiagnostic.java (3 hunks)
Additional comments not posted (4)
src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/RewriteMethodParameterDiagnostic.java (2)
158-165: Изменение одобрено.Использование
ParseTree::getParentвместоRuleNode::getParentповышает гибкость при обработке различных типов узлов разбора.
175-175: Изменение одобрено.Использование
ParseTree::getParentвместоTerminalNode::getParentповышает гибкость при обработке различных типов узлов разбора.build.gradle.kts (2)
83-83: Обновление зависимости одобрено.Обновление
bsl-parserдо версии0.25.0вероятно включает исправления ошибок, улучшения производительности и новые функции. Убедитесь, что новая версия совместима с остальной частью проекта.
93-93: Обновление зависимости одобрено.Обновление
bsl-parser-coreдо версии0.2.0вероятно включает исправления ошибок, улучшения производительности и новые функции. Убедитесь, что новая версия совместима с остальной частью проекта.
Qodana for JVM76 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Detected 101 dependenciesThird-party software listThis page lists the third-party software dependencies used in bsl-language-server
Contact Qodana teamContact us at qodana-support@jetbrains.com
|
|
/rebase |
theshadowco
force-pushed
the
feature/bumpantlr
branch
from
78f6110 to
5e22a78
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- build.gradle.kts (2 hunks)
- src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/RewriteMethodParameterDiagnostic.java (3 hunks)
Files skipped from review as they are similar to previous changes (2)
- build.gradle.kts
- src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/RewriteMethodParameterDiagnostic.java
|
theshadowco
force-pushed
the
feature/bumpantlr
branch
from
5e22a78 to
b7a9fdd
Compare
Qodana for JVM78 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Detected 103 dependenciesThird-party software listThis page lists the third-party software dependencies used in bsl-language-server
Contact Qodana teamContact us at qodana-support@jetbrains.com
|
|
Описание
Обновлены зависимости,теперь используется собственная библиотека ANTLR
Связанные задачи
Closes
Чеклист
Общие
gradlew precommit)Для диагностик
Дополнительно