-
Notifications
You must be signed in to change notification settings - Fork 54
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more funny phrases! #6
Comments
Is there a character limit? |
@chitchu Around 80 chars (more importantly, they should be able to fit on one line) |
Gotcha. FYI line 37 is 91 characters long. |
i would like to add some phrases. Can i? |
@collinx Go for it! |
@1egoman Hey, i'd like to add more phrases. Is there any domain on the jokes that can be made or can we add anything humorous? |
@FleetAdmiral A few requirements:
Other than that, not really. I'll be more likely to accept a PR if I think it's funny though 😄 ! |
@1egoman Awesome! BTW, great project you've got going on over here, pity i hadn't heard of it (i have a thing for fun projects). Keep working on it (will love to contribute more tbh) ! |
@FleetAdmiral Thanks! Always looking for more funny jokes! |
* Contributing to issue #6, added more funnies Let me know if you don't line some of them or want any changes! * fixed typo
* Update funnies.js Add more funny phrases! #6 * Update funnies.js
@1egoman can you add a label to this Issue indicating that it is good for beginner level? Suggestion something like "low-hanging-fruit". Would like to include it in a listing of repositories for good beginner PR's. |
@jeremytbrun Good idea! |
I'll try to think of something that hasn't been added already :) |
* Add some "jokes" * Made joke funnier! * Reverse accidental change of double- to singel-quotes
We can always use more funny phrases!
Add them to the array in here, as strings. Make sure you add a trailing comma to the end of the array to attempt to make each merge as clean as possible, though it's unlikely that the merge will be 100% clean with this issue.
This is a great first pull-request for those unfamiliar with Github. Feel free to ask for assistance if you need some help!
The text was updated successfully, but these errors were encountered: