-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SC-1044][SC-1070] Refactor _postInteraction #145
[SC-1044][SC-1070] Refactor _postInteraction #145
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #145 +/- ##
==========================================
+ Coverage 91.74% 92.38% +0.63%
==========================================
Files 8 11 +3
Lines 206 210 +4
Branches 32 32
==========================================
+ Hits 189 194 +5
+ Misses 17 16 -1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Xenia <94478708+byshape@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest adding a test for the case when we have both an integrator and resolver fee simultaneously.
WhitelistExtension
,FeeIntegratorExtension
andFeeResolverExtension
use the last byte in theextraData
as bitmap with additional info. You can find descriptions in_postIntegration
's natspecs.