Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SC-1044][SC-1070] Refactor _postInteraction #145

Merged
merged 10 commits into from
Feb 16, 2024

Conversation

zZoMROT
Copy link
Contributor

@zZoMROT zZoMROT commented Feb 7, 2024

WhitelistExtension, FeeIntegratorExtension and FeeResolverExtension use the last byte in the extraData as bitmap with additional info. You can find descriptions in _postIntegration's natspecs.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (002f770) 91.74% compared to head (d3d59e6) 92.38%.

Files Patch % Lines
contracts/extensions/WhitelistExtension.sol 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
+ Coverage   91.74%   92.38%   +0.63%     
==========================================
  Files           8       11       +3     
  Lines         206      210       +4     
  Branches       32       32              
==========================================
+ Hits          189      194       +5     
+ Misses         17       16       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zZoMROT and others added 2 commits February 7, 2024 15:32
Co-authored-by: Xenia <94478708+byshape@users.noreply.github.com>
Copy link
Contributor

@byshape byshape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest adding a test for the case when we have both an integrator and resolver fee simultaneously.

contracts/extensions/WhitelistExtension.sol Outdated Show resolved Hide resolved
test/helpers/fusionUtils.js Outdated Show resolved Hide resolved
@zZoMROT zZoMROT requested a review from byshape February 12, 2024 20:05
@zZoMROT zZoMROT changed the title [SC-1044] Refactor _postInteraction [SC-1044][SC-1070] Refactor _postInteraction Feb 13, 2024
@ZumZoom ZumZoom merged commit 845b207 into master Feb 16, 2024
7 checks passed
@ZumZoom ZumZoom deleted the feature/postInteraction-functional-decomposition branch February 16, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants