Add resolveQueryFromOperation and JSDoc comments #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robrichard
reviewed
Nov 1, 2018
index.js
Outdated
| // See https://github.com/facebook/relay/issues/1816 | ||
| const query = | ||
| operation.text || | ||
| (resolveQueryFromOperation && resolveQueryFromOperation(operation)); |
There was a problem hiding this comment.
Should we always call resolveQueryFromOperation if it's passed? It might be useful to transform it in some way unrelated to persisted queries?
There was a problem hiding this comment.
I think that's reasonable yeah, could basically just flip the order of this ||
|
@javamonn thanks for the PR. I just added my preferred prettier config to the repo. Can you re-run your changes using this config? |
javamonn
force-pushed
the
add-query-resolver
branch
from
7e16c4e to
6c98833
Compare
|
@robrichard I've updated this in response to your comment and rebased on top of the latest prettier changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolveQueryFromOperationparameter that is used to resolve the operation query text in cases whenoperation.textis missing. We have a persisted query implementation in which only a query ID is compiled into the query artifact, and this ID is normally resolved into the full query text on the server. In the case ofrelay-mock-network-layerhowever we need a way to perform this resolution client side. See Port Relay test tooling from Reaction, update to Node 10 artsy/emission#1209 (comment) for more information./cc @orta