Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong log message for received json #931

Closed
Legion2 opened this issue Apr 25, 2021 · 1 comment
Closed

Wrong log message for received json #931

Legion2 opened this issue Apr 25, 2021 · 1 comment
Labels

Comments

@Legion2
Copy link
Contributor

Legion2 commented Apr 25, 2021

Describe the bug
The logJson function is used by receivingMQTT and pub, to log the json which is send and received.
However, the log message text is always Received json : %s.
This means also when sending json, in the logs it shows as received json.

To Reproduce
Steps to reproduce the behavior:

  1. Open the serial monitor
  2. Wait for SYStoMQTT
  3. See wrong log message

Expected behavior
The log message should either indicate the correct action (sending, receiving) or exclude this information from the log.

Screenshots

N: Subject: /SYStoMQTT
N: Received json : {"uptime":1803,"version":"v0.9.6","freemem":206120,...}
T: jsonPublishing

Environment:

  • OpenMQTTGateway version: development

Additional context
I use log level LOG_LEVEL_VERBOSE.

Odyno added a commit to Odyno/OpenMQTTGateway that referenced this issue May 6, 2021
Odyno added a commit to Odyno/OpenMQTTGateway that referenced this issue May 6, 2021
Odyno added a commit to Odyno/OpenMQTTGateway that referenced this issue May 6, 2021
Odyno added a commit to Odyno/OpenMQTTGateway that referenced this issue May 11, 2021
Odyno added a commit to Odyno/OpenMQTTGateway that referenced this issue Jul 7, 2021
Odyno added a commit to Odyno/OpenMQTTGateway that referenced this issue Jul 7, 2021
@stale
Copy link

stale bot commented Jul 21, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 21, 2021
1technophile pushed a commit that referenced this issue Nov 2, 2021
… also #931)  (#1093)

* Rationalisation of logs and removal of duplicate codes
@stale stale bot closed this as completed Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant