-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for BME280 Temperature Correction #1062
Support for BME280 Temperature Correction #1062
Conversation
The Spark Fun BME 280 library has support for Temperature correction, and this pull request implements the ability to apply a correction via a compiler directive ( BME280Correction ).
I found that with my esp32's, cc1101 and bme280 all in the same case the temperature reading was always high. |
Nice, could you add this macro into the .h config file for the BME280 please, so that the users know that this is available? Also, you could activate it into some *-test environments to verify that the build works with it. |
I changed the macro logic based on your recommendation and define it in the BME280 config file. And have added PS Any tips on flattening the commits? |
@NorthernMan54 git rebase -i then mark the extra commits with |
Thanks. Don't worry I will squash them. |
Tks |
Description:
The Spark Fun BME 280 library has support for Temperature correction, and this pull request implements the ability to apply a correction via a compiler directive ( BME280Correction ).
Correction is in celcius of temperature reported by bme280 sensor. Both Celcius and Farenheit tempaeratures are adjusted.
Value is a float
ie Compiler Directive '-DBME280Correction=-3.4'
Checklist: