Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for BME280 Temperature Correction #1062

Merged
merged 6 commits into from
Aug 17, 2021
Merged

Support for BME280 Temperature Correction #1062

merged 6 commits into from
Aug 17, 2021

Conversation

NorthernMan54
Copy link
Collaborator

Description:

The Spark Fun BME 280 library has support for Temperature correction, and this pull request implements the ability to apply a correction via a compiler directive ( BME280Correction ).

Correction is in celcius of temperature reported by bme280 sensor. Both Celcius and Farenheit tempaeratures are adjusted.
Value is a float
ie Compiler Directive '-DBME280Correction=-3.4'

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

The Spark Fun BME 280 library has support for Temperature correction, and this pull request implements the ability to apply a correction via a compiler directive ( BME280Correction ).
@1technophile 1technophile added this to the v0.9.9 milestone Aug 16, 2021
@NorthernMan54
Copy link
Collaborator Author

I found that with my esp32's, cc1101 and bme280 all in the same case the temperature reading was always high.

@1technophile
Copy link
Owner

Nice, could you add this macro into the .h config file for the BME280 please, so that the users know that this is available? Also, you could activate it into some *-test environments to verify that the build works with it.

@NorthernMan54
Copy link
Collaborator Author

I changed the macro logic based on your recommendation and define it in the BME280 config file. And have added BME280Correction to the esp32dev-all-test environment.

PS Any tips on flattening the commits?

@h2zero
Copy link
Collaborator

h2zero commented Aug 16, 2021

@NorthernMan54 git rebase -i then mark the extra commits with s or squash. Then force push to the branch. However, it can be done by the github interface anyway so there isn't really a need unless you want to.

@1technophile
Copy link
Owner

Thanks. Don't worry I will squash them.
For your knowledge you can also take the first commit sha and rebase from it
git rebase -i <sha>, a text editor will open, put an s in front of the commit you want to squash, save
and after do a git push -f

@NorthernMan54
Copy link
Collaborator Author

Tks

@1technophile 1technophile merged commit 94a7792 into 1technophile:development Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants