Remove std::string as the model id and use decoder enum. #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h2zero
force-pushed
the
model-id-enums
branch
from
9f0f524 to
2c0ad43
Compare
h2zero
force-pushed
the
model-id-enums
branch
4 times, most recently
from
439385a to
82a1e2f
Compare
* Update decoder version
h2zero
force-pushed
the
model-id-enums
branch
from
82a1e2f to
e2aba32
Compare
h2zero
added a commit
to h2zero/OpenMQTTGateway
that referenced
this pull request
Jan 24, 2022
This allows for connecting to devices that do not use the MAC address type 0. This also adds the logging of the "mac_type" so it is visible to users trying to connect to broadcasting devices. Additionally this will allow for future connectable devices using a MAC address type other than 0 to be automatically connected to when support is added for them, similar to LYWSD03MMC etc.. Uses: 1technophile#1143
3 tasks
h2zero
added a commit
to h2zero/OpenMQTTGateway
that referenced
this pull request
Jan 24, 2022
This allows for connecting to devices that do not use the MAC address type 0. This also adds the logging of the "mac_type" so it is visible to users trying to connect to broadcasting devices. Additionally this will allow for future connectable devices using a MAC address type other than 0 to be automatically connected to when support is added for them, similar to LYWSD03MMC etc.. Uses: 1technophile#1143
* Add BLEconnect enum MIN/MAX
h2zero
added a commit
to h2zero/OpenMQTTGateway
that referenced
this pull request
Jan 25, 2022
This allows for connecting to devices that do not use the MAC address type 0. This also adds the logging of the "mac_type" so it is visible to users trying to connect to broadcasting devices. Additionally this will allow for future connectable devices using a MAC address type other than 0 to be automatically connected to when support is added for them, similar to LYWSD03MMC etc.. Uses: 1technophile#1143
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This reduces the memory cost of std::string use and improves performance.
Checklist: