Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenHAB discovery #1153

Merged
merged 3 commits into from
Feb 3, 2022
Merged

Conversation

kabili207
Copy link
Contributor

Description:

Enabling OpenHAB discovery breaks the build as it expects defines only present in the HASS define set

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

@1technophile
Copy link
Owner

Thanks for this, could you add also to the PR a test environment with OpenHAB auto-discovery. This will enable us to verify that the build is monitored for this configuration at each change.

@1technophile 1technophile added this to the V1.0 milestone Feb 2, 2022
@kabili207
Copy link
Contributor Author

@1technophile Test env has been added

@1technophile
Copy link
Owner

Perfect!

@1technophile 1technophile merged commit 457a8f4 into 1technophile:development Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants