[HA Discovery] Remove auto discovery switch #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1technophile
changed the title
1technophile
force-pushed
the
remove-auto-discovery-switch
branch
from
ae41c5f to
ec790c7
Compare
I don't think there is usage for such a switch into HA, if you see it, auto discovery was already activated and all the entities created, so you will have to go to the mqtt client to remove the retained messages. If you don't want auto discovery as an HA user you would have to go to the mqtt client to send the discovery message deactivation. So either way as a HA user you have to go to a client. And as people not wanting to use auto discovery with HA are the people that are not using HA this switch as a little value.
1technophile
force-pushed
the
remove-auto-discovery-switch
branch
from
ec790c7 to
a375166
Compare
3 tasks
1technophile
added a commit
that referenced
this pull request
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I don't think there is usage for such a switch into HA discoveryconvention, if you see it, auto discovery was already activated and all the entities created, so you will have to go to the mqtt client to remove the retained messages.
If you don't want auto discovery as an HA convention user you would have to go to the mqtt client to send the discovery message deactivation.
So either way as a HA user you have to go to a client.
And as people not wanting to use auto discovery with HA convention are the people that are not using HA convention, this switch as a little value.
Prereq #1364
Checklist: