Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTA] Capability to disable Firmware Update on ESP32 WEB #1621

Merged
merged 5 commits into from
May 2, 2023

Conversation

bwynants
Copy link
Contributor

@bwynants bwynants commented Apr 28, 2023

Description:

there is a compile error when '-UMQTT_HTTPS_FW_UPDATE' is set in the build flags with an ESP32

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

@1technophile
Copy link
Owner

Thanks for the PR,

Could you add the macro to this environment:

[env:esp32dev-all-test]

This way it will be tested by the CI

@NorthernMan54
Copy link
Collaborator

@bwynants Question - Why do you have the MQTT_HTTPS_FW_UPDATE directive set ? Should the scope of MQTT_HTTPS_FW_UPDATE be changed to still enable the WebUI firmware upgrade use case ?

@bwynants
Copy link
Contributor Author

@bwynants Question - Why do you have the MQTT_HTTPS_FW_UPDATE directive set ? Should the scope of MQTT_HTTPS_FW_UPDATE be changed to still enable the WebUI firmware upgrade use case ?

because i do not want that kind of updating? i upload my firmware updates via 'ota' saves me some space on the ESP

@bwynants
Copy link
Contributor Author

This way it will be tested by the CI

but CI would not test updates via WEB UI anymore. do you want that?

@1technophile
Copy link
Owner

but CI would not test updates via WEB UI anymore. do you want that?

It will be tested by the other environments

@1technophile 1technophile changed the title disabling Firmware Update on ESP32 WEB [OTA] disabling Firmware Update on ESP32 WEB May 2, 2023
@1technophile 1technophile changed the title [OTA] disabling Firmware Update on ESP32 WEB [OTA] Capability to disable Firmware Update on ESP32 WEB May 2, 2023
@1technophile
Copy link
Owner

Thanks

@1technophile 1technophile merged commit 9bb322d into 1technophile:development May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants