fix repeater adjusting time of date #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
munen
force-pushed
the
fix/repeater-dot-plus
branch
from
68e1040
to
670eb7a
Compare
|
Hi @tarnung Good job on this PR! 🙏 I confirm your statements on how the repeaters work. I have also added tests to showcase it. Unfortunately, adding these new tests makes an old test fail and I do not understand why. I have spent quite a bit of time trying to figure out what the problem is, but it shouldn't block merging this PR as it is unrelated. I'll open a separate PR for it. Great job, thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #683
Since I'm still not using emacs, someone might want to check if my assumptions based on org mode docs are correct.
using ".+":