-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: suggestion for clock:now #747
Conversation
I added a basic indicator for active clocks. It checks for them when parsing the org file and updates their number when clocking in/out. |
The indicator can get out of sync when headers with active clocks are deleted. Maybe there's a more robust implementation, maybe this is good enough as it corrects itself on the next file parse. |
Nice PR!
A
will become:
Example taken from https://github.com/200ok-ch/organice/blob/master/test_helpers/fixtures/various_todos.org#repeating-task Relevant Org mode doc: https://orgmode.org/manual/Drawers.html Having said that, your |
I have gone through the code and tested it. It works for me and I like the implementation. I haven't merged, yet, for this reason: Since the magnifying glass already changes color, I'd say this PR also needs the icon that populates a search with |
this pr is replaced by #751 if the changes over there are accepted |
Nice job on this, thanks for implementing @tarnung! |
A quick and dirty implementation for parts of the feature set described in #737
=> clock:now searches for active clocks
I thought that other things than clocks can create "logBookEntries". But maybe i misremember. I could not find any in my demo files.
This pull request does not address the issue #745. Since it does not add to the problem we can go along and refactor later once @schoettl and I what if anything should be done.