Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile build fix on CircleCI #915

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Dockerfile build fix on CircleCI #915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41af89d
Dockerfile fix
Dec 8, 2022
b0badcc
Update config.yml
mohitsaxenaknoldus Dec 8, 2022
2f037be
Update config.yml
mohitsaxenaknoldus Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,16 +135,4 @@ workflows:
filters:
branches:
only: develop
# FIXME: This used to work and broke due to erosion
# Related issue: https://github.com/200ok-ch/organice/issues/909
# - push-image:
# requires:
# # Staging deployments are free of linting and test checks,
# # so that we can quickly build, deploy and iterate.
# # There's still visual feedback on Github on whether or
# # not the tasks failed.
# # - build # because of tests
# # - build-docs
# filters:
# branches:
# only: master
- push-image
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ COPY . /opt/organice

RUN bin/transient_env_vars.sh bait >> .env

RUN yarn global add serve \
RUN yarn global add serve --ignore-engines \
&& yarn build \
&& yarn cache clean \
&& rm -rf node_modules
Expand Down