Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array indentation gets broken #58

Closed
chitoku-k opened this issue Aug 16, 2017 · 2 comments
Closed

Array indentation gets broken #58

chitoku-k opened this issue Aug 16, 2017 · 2 comments
Assignees

Comments

@chitoku-k
Copy link

chitoku-k commented Aug 16, 2017

I encountered a buggy behavior in array indentation that can be reproducible in following steps:

  1. Run Vim without .vimrc: vim -u NORC
  2. let g:PHP_vintage_case_default_indent = 1
  3. set ft=php
  4. Input some code which contains array(s):
<?php
$x = [
];
$y = array(
);

after hitting return, the indentation becomes like this:

<?php
$x = [
    ];
$y = array(
    );

This does not happen when g:PHP_vintage_case_default_indent is disabled (default).

Environment: Vim version 8.0.946

Thank you.

@2072 2072 self-assigned this Sep 10, 2017
@2072
Copy link
Owner

2072 commented Sep 24, 2017

This should be fixed now.

@2072 2072 closed this as completed Sep 24, 2017
@chitoku-k
Copy link
Author

Yes it is! Thanks.

2072 added a commit to 2072/vim that referenced this issue May 18, 2018
Changes since 1.62:

- Fix chained multi-line '->' indentation (issue 2072/PHP-Indenting-for-VIm#54 and 2072/PHP-Indenting-for-VIm#59)
- Add a new PHP_noArrowMatching option to disable '->' indentation matching on multi-line chained calls (issue 2072/PHP-Indenting-for-VIm#59).
- Add support for return type declaration on multi-line function declarations (issue 2072/PHP-Indenting-for-VIm#64)
- Fix array indentation when PHP_vintage_case_default_indent is set (issue 2072/PHP-Indenting-for-VIm#58)
- Always ignore case when using syntax highlighting names (issue 2072/PHP-Indenting-for-VIm#52)
- Functions declared as returning references were not indented properly (issue 2072/PHP-Indenting-for-VIm#62).
- Fix to multi-line function declaration argument indentation (issue 2072/PHP-Indenting-for-VIm#63)
2072 added a commit to 2072/vim that referenced this issue May 18, 2018
Changes since 1.62:

- Fix chained multi-line '->' indentation (issue 2072/PHP-Indenting-for-VIm#54 and 2072/PHP-Indenting-for-VIm#59)
- Add a new PHP_noArrowMatching option to disable '->' indentation matching on multi-line chained calls (issue 2072/PHP-Indenting-for-VIm#59).
- Add support for return type declaration on multi-line function declarations (issue 2072/PHP-Indenting-for-VIm#64)
- Fix array indentation when PHP_vintage_case_default_indent is set (issue 2072/PHP-Indenting-for-VIm#58)
- Always ignore case when using syntax highlighting names (issue 2072/PHP-Indenting-for-VIm#52)
- Functions declared as returning references were not indented properly (issue 2072/PHP-Indenting-for-VIm#62).
- Fix to multi-line function declaration argument indentation (issue 2072/PHP-Indenting-for-VIm#63)
2072 added a commit to 2072/vim that referenced this issue May 18, 2018
Changes since 1.62:

- Fix chained multi-line '->' indentation (issue 2072/PHP-Indenting-for-VIm#54 and 2072/PHP-Indenting-for-VIm#59)
- Add a new PHP_noArrowMatching option to disable '->' indentation matching on multi-line chained calls (issue 2072/PHP-Indenting-for-VIm#59).
- Add support for return type declaration on multi-line function declarations (issue 2072/PHP-Indenting-for-VIm#64)
- Fix array indentation when PHP_vintage_case_default_indent is set (issue 2072/PHP-Indenting-for-VIm#58)
- Always ignore case when using syntax highlighting names (issue 2072/PHP-Indenting-for-VIm#52)
- Functions declared as returning references were not indented properly (issue 2072/PHP-Indenting-for-VIm#62).
- Fix to multi-line function declaration argument indentation (issue 2072/PHP-Indenting-for-VIm#63)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants