Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mpl and multithreading #84

Closed
wants to merge 8 commits into from
Closed

Fix mpl and multithreading #84

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d7fa2b1
1) fix colormaps.register for new mpl version
Kojobu Jun 25, 2024
458cc4c
1) fix colormaps.register for new mpl version
Kojobu Jun 25, 2024
42bf1d7
change to schwimmbad for better escape behavoir
Kojobu Jun 26, 2024
febc426
fix mp
Kojobu Jun 26, 2024
2814ca0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 26, 2024
6680498
rechange
Kojobu Jun 26, 2024
1db74e8
Merge branch 'master' of github.com:Kojobu/21CMMC
Kojobu Jun 26, 2024
dfb3d9e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/py21cmmc/mcmc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
from py21cmfast import yaml
from py21cmfast._utils import ParameterError

# from concurrent.futures import ProcessPoolExecutor
from schwimmbad import MultiPool

from .cosmoHammer import (
CosmoHammerSampler,
HDFStorageUtil,
Expand Down Expand Up @@ -577,9 +580,14 @@ def prior(p):
return sampler, result

else:
# didn't spawn Pools in my case, setting mp_context (either spawn or fork) fixed it
pool = mcmc_options.pop(
"pool",
ProcessPoolExecutor(max_workers=mcmc_options.get("threadCount", 1)),
ProcessPoolExecutor(
max_workers=mcmc_options.get("threadCount", 1),
max_tasks_per_child=1,
mp_context="spawn",
),
)
sampler = sampler_cls(
continue_sampling=continue_sampling,
Expand Down
Loading