-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v3.3.0 #327
Merged
Merged
Release v3.3.0 #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or non-cubic boxes
…ion_test_data.py file. The tests generated tests/test_data/power_spectra_cmb_heating.h5, tests/test_data/power_spectra_lyman_alpha_heating.h5 files.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
The heating PR from debanjan, now a 21cmfast-native one
Fix adiabatic fluctuations in Tk at high z
…to functions (though not sure why they needed updating...)
Non cubic
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## production #327 +/- ##
==============================================
+ Coverage 86.33% 86.60% +0.27%
==============================================
Files 12 12
Lines 2780 2814 +34
==============================================
+ Hits 2400 2437 +37
+ Misses 380 377 -3
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internals
repetition.
Fixed
R_BUBBLE_MAX
too large auto-fixes it to beBOX_LEN
([BUG] Box fails for R_BUBBLE_MAX > BOX_LEN #112)clear_cache
.between low-level code (eg.
spin_temperature()
) and high-level code (eg.run_coeval()
).Added
validate_all_inputs
function that cross-references the four main input structsand ensures all the parameters make sense together. Mostly for internal use.
across all neighbouring cells instead of the previous nearest cell approach
scenarios in line with current observations ([BUG] Photon conservation seems unstable when using a pre-calibration late EoR #305)
arising for early EOR histories (Segmentation Fault when using photon conservation #311)
NON_CUBIC_FACTOR
toUserParams
to allow for non-cubic coeval boxes (Non cubic #289)