fix trapezoidal bug, make error messages more clear #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v4-prep #442 +/- ##
===========================================
- Coverage 79.58% 79.57% -0.02%
===========================================
Files 24 24
Lines 3782 3779 -3
Branches 642 642
===========================================
- Hits 3010 3007 -3
Misses 556 556
Partials 216 216 ☔ View full report in Codecov by Sentry. |
steven-murray
approved these changes
Nov 19, 2024
daviesje
force-pushed
the
minihalo-bufgix
branch
from
125fec4 to
021ee30
Compare
daviesje
force-pushed
the
minihalo-bufgix
branch
from
021ee30 to
c9e68d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally broke the trapezoidal integrals in (z,Mturn) in the Ionisation box refactor (USE_HALO_FIELD=False, USE_MINI_HALOS=True). This fixes the issue and makes the error messages regarding those integrals clearer