-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve exchange rate calculation #70
Improve exchange rate calculation #70
Conversation
Nice, its working! I think it will help to calculate a more accurate exchange rate. I was a bit confused by the decimal place in the exchange rate. Especially since he sometimes shows one or two. Maybe one would be enough. The first picture shows a calculation without the changes and the other two with the change. |
Thanks for testing and your feedback @AxelHamburch! 🙌 I agree that space is very limited and we could just displace one decimal place as this is just an additional info for the user. The final amount will be calculated with the exact exchange rate, anyways. I'll update the MR. |
Great! What do you think @lightisfaster ? |
@AxelHamburch I still need to incorporate your feedback. 😅 I'll have the MR ready later this week. |
c85b966
to
01af775
Compare
@AxelHamburch I just updated the MR. Should be ready to merge! |
Hey, looks good for me, i've test it too. Thanks for feedback @AxelHamburch. Good job @reneaaron and sorry for the delay. The alignment of the text may need to be adjusted for a display type, but this is trade off we can accept. |
I did test it with a
waveshare2in13v2
display, other displays unfortunately remain untested.