Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI-3111: Added privacy to callflow editor #69

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

UI-3111: Added privacy to callflow editor #69

wants to merge 4 commits into from

Conversation

sergey-safarov
Copy link

reopened PR #34

joristirado
joristirado suggested changes Sep 16, 2019
View reviewed changes
submodules/misc/misc.js Outdated Show resolved Hide resolved
submodules/misc/misc.js Outdated Show resolved Hide resolved
views/misc-privacy.html Outdated Show resolved Hide resolved
@sergey-safarov
Copy link
Author

I have resolved requested changes. Please look additional commits.
If PR acceptable for you, then I make local PR test after updates.

joristirado
joristirado reviewed Sep 17, 2019
View reviewed changes
Copy link
Contributor

@joristirado joristirado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me, can't merge until the module's id is updated from privacy to privacy_cid in Kazoo.

@sergey-safarov
Copy link
Author

Are you want rename applications/callflow/src/module/cf_privacy.erl to applications/callflow/src/module/cf_privacy_cid.erl in kazoo repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joristirado joristirado joristirado requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sergey-safarov @joristirado