Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add hold i_s #971

Merged
merged 4 commits into from
Sep 15, 2023
Merged

add hold i_s #971

merged 4 commits into from
Sep 15, 2023

Conversation

ImpleLee
Copy link
Contributor

@ImpleLee ImpleLee commented Sep 13, 2023 •
edited
Loading

closes #646 .

@ImpleLee ImpleLee changed the title Imple/add hold i s add hold i s Sep 13, 2023
@ImpleLee ImpleLee changed the title add hold i s add hold i_s Sep 13, 2023
@ImpleLee

This comment was marked as resolved.

Sign in to view
@ImpleLee ImpleLee marked this pull request as draft September 13, 2023 20:19
@ImpleLee ImpleLee marked this pull request as ready for review September 14, 2023 09:11
@ImpleLee
bump room version
996d62b 
hold i_s is not back-compatible
@MrZ626 MrZ626 merged commit 337293d into main Sep 15, 2023
11 checks passed
@MrZ626 MrZ626 deleted the imple/add-hold-i_s branch September 15, 2023 17:35
MrZ626
MrZ626 reviewed Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@MrZ626 MrZ626 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@ImpleLee ImpleLee mentioned this pull request Nov 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrZ626 MrZ626 MrZ626 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make death delay also trigger when holding if the held piece will cause overlap
2 participants
@ImpleLee @MrZ626