Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the label of the show/hide icon to sentence case #1

Open
ggeisler opened this issue Jul 30, 2021 · 1 comment
Open

Change the label of the show/hide icon to sentence case #1

ggeisler opened this issue Jul 30, 2021 · 1 comment

Comments

@ggeisler
Copy link

This plugin is a nice option for cases when displaying the annotation text directly over the canvas is not likely to negatively affect the user experience.

One very minor suggestion: For consistency purposes, I suggest you update the label text for the show/hide icon to use sentence case, rather than the current title case:

Screen Shot 2021-07-30 at 3 59 45 PM

So where the current labels are Show Annotation Tooltip and Hide Annotation Tooltip, they would be changed to Show annotation tooltip and Hide annotation tooltip.

This change would make the label consistent with the rest of the Mirador UI, which uses sentence case (for English).

aria-label={annotationTooltipEnabled ? 'Hide Annotation Tooltip' : 'Show Annotation Tooltip'}

@2SC1815J
Copy link
Owner

Thank you for the suggestion. I have updated the label text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants