Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic URL handling system for servers that don't support the TTVLOL API #30

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

2bc4
Copy link
Owner

@2bc4 2bc4 commented Mar 13, 2023

Instead of supporting each API individually allow passing a custom URL. If the URL includes "[channel]" it will be replaced with the real channel name similar to the Xtra app, otherwise defaults to the TTVLOL API. It should work as long as the API doesn't require something like a custom header or URL encoding (TTVLOL).

Tested with Purple Adblock: --twitch-proxy-playlist="https://eu1.jupter.ga/channel/[channel]" and luminous native API: --twitch-proxy-playlist="https://eu.luminous.dev/live/[channel]"

@2bc4
Copy link
Owner Author

2bc4 commented Mar 13, 2023

@thinkpad4 Would it be possible to test if the config works in this version? It does on my end but I want to rule out differences between setups.

{channel} was changed to [channel]

twitch-proxy-playlist=https://eu1.jupter.ga/channel/[channel]

@2bc4 2bc4 marked this pull request as ready for review March 13, 2023 03:15
@thinkpad4
Copy link

Tested the new version of twitch.py and purple works with config now. Thank you very much

Instead of supporting each API individually allow passing a custom URL. If the URL includes "[channel]" it will be replaced with the real channel name similar to the Xtra app, otherwise defaults to the TTVLOL API. It should work as long as the API doesn't require something like a custom header or URL encoding (TTVLOL).

Tested with Purple Adblock: --twitch-proxy-playlist="https://eu1.jupter.ga/channel/[channel]" and luminous native API: --twitch-proxy-playlist="https://eu.luminous.dev/live/[channel]"
@2bc4 2bc4 reopened this Mar 13, 2023
@2bc4 2bc4 merged commit a131607 into master Mar 13, 2023
@2bc4 2bc4 deleted the generic-url branch March 13, 2023 05:02
@2bc4 2bc4 added the enhancement New feature or request label Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants