I-134 Add --in-cluster key for provisioner #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
==========================================
- Coverage 78.49% 78.19% -0.30%
==========================================
Files 22 22
Lines 1432 1440 +8
==========================================
+ Hits 1124 1126 +2
- Misses 308 314 +6
Continue to review full report at Codecov.
|
| @@ -161,6 +169,8 @@ def _handler_provision(command, resources, priority_evaluator, use_kubeconfig, s | |||
| help='Check existence of all env variables in config.yaml and stop if var is not set') | |||
| parser_provisioning.add_argument('--use-kubeconfig', action='store_true', required=False, | |||
| help='Try to use kube config') | |||
| parser_provisioning.add_argument('--in-cluster', action='store_true', required=False, | |||
There was a problem hiding this comment.
It think that if kube-config configuration and in-cluster configuration options are mutually exclusive by idea and by design, they should be mutually exclusive at arguments parser's level as well.
Now we can specify both and the kube-config will be implicitly used.
As a little effort, I'd try to add them into add_mutually_exclusive_group(), if it works correctly with subparsers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #135