Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CITYLENS-728] Add citylens-routes-ui chart #540

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[CITYLENS-728] Add citylens-routes-ui chart #540

wants to merge 2 commits into from

Conversation

xalvaine
Copy link

Check-list. Чек-лист код-ревью

  • Запрос на слияние в develop.
  • Есть описание к PR.
  • Указаны блокирующие изменения. Breaking-Changes
  • Соответствие кода принятому стилю
    • Описание настроек.
    • Именование настроек.
    • Дефолтные значения.
    • Стиль кода.
  • Работоспособность. Разворачивается на своем окружении из ветки PR.
    • Тест API через тесты helmfile-хуков или коллекций Postman.
  • Не осталось мусора от удаления каких-то параметров. Ищется поиском по проекту из ветки PR.
  • Отработка линтера на чарт из ветки PR. Пример: helm lint charts/search-api

@xalvaine xalvaine requested review from a team as code owners November 27, 2024 07:02
@xalvaine xalvaine force-pushed the citylens-routes-ui branch 10 times, most recently from a86825c to 21ef7e6 Compare December 4, 2024 17:33
@xalvaine xalvaine force-pushed the citylens-routes-ui branch 4 times, most recently from 0416d51 to 2372030 Compare December 11, 2024 18:32
@xalvaine xalvaine force-pushed the citylens-routes-ui branch 2 times, most recently from 533888d to 26a6bb6 Compare December 13, 2024 21:19
@dbelyaev-nsk
Copy link
Contributor

задача на проверку https://jira.2gis.ru/browse/ONPREM-1400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbelyaev-nsk dbelyaev-nsk dbelyaev-nsk left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xalvaine @dbelyaev-nsk