-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade JNA to latest version to avoid problems when running gigaspac… #10
Conversation
…es tests using testcontainers on apple mac M1 The 5.6.0 version of jna doesn't work on apple mac m1, this is fixed in 5.7.0, but this commit suggests upgrading to the latest version, which currently is 5.13.0 jna has no transitive dependencies and jna release notes does not mention any problems upgrading to 5.13.0 for more info: https://github.com/java-native-access/jna/blob/master/CHANGES.md java-native-access/jna#1238 https://www.testcontainers.org/
Important Auto Review SkippedReview was skipped due to path filters Files ignored due to path filters (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Fixing PR: track the progress here.I'm currently fixing this PR to address the following: [Sweep GHA Fix] The GitHub Actions run failed with the following error logs:
An error has occurred: Message is too long, max tokens is -6704 (tracking ID: c802b9ab3a) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Type: Enhancement
PR Summary: The pull request upgrades the JNA library to the latest version to ensure compatibility with Apple Mac M1 when running gigaspaces tests using testcontainers.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
- Unsupported files: the diff contains files that Sourcery does not currently support during reviews.
General suggestions:
- Ensure that the upgrade does not introduce any breaking changes or incompatibilities with existing code that relies on JNA.
- Verify that all tests pass on multiple platforms, including the Apple Mac M1, to confirm that the upgrade has not introduced any regressions.
- Consider adding a brief note in the documentation or change log to inform users about the upgrade and any potential impacts on their current setups.
Your trial expires on February 1, 2024. Please email tim@sourcery.ai to continue using Sourcery ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
…es tests using testcontainers on apple mac M1
The 5.6.0 version of jna doesn't work on apple mac m1, this is fixed in 5.7.0, but this commit suggests upgrading to the latest version, which currently is 5.13.0
jna has no transitive dependencies and jna release notes does not mention any problems upgrading to 5.13.0
for more info:
https://github.com/java-native-access/jna/blob/master/CHANGES.md java-native-access/jna#1238 https://www.testcontainers.org/
Description
Related Issue
Types of changes
Checklist: