Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade JNA to latest version to avoid problems when running gigaspac… #10

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

2lambda123
Copy link
Owner

…es tests using testcontainers on apple mac M1

The 5.6.0 version of jna doesn't work on apple mac m1, this is fixed in 5.7.0, but this commit suggests upgrading to the latest version, which currently is 5.13.0

jna has no transitive dependencies and jna release notes does not mention any problems upgrading to 5.13.0

for more info:

https://github.com/java-native-access/jna/blob/master/CHANGES.md java-native-access/jna#1238 https://www.testcontainers.org/

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the Code of Conduct
  • I have updated the documentation accordingly.
  • All commits are GPG signed

…es tests using testcontainers on apple mac M1

The 5.6.0 version of jna doesn't work on apple mac m1, this is fixed in 5.7.0, but this commit suggests upgrading to the latest version, which currently is 5.13.0

jna has no transitive dependencies and jna release notes does not mention any problems upgrading to 5.13.0

for more info:

https://github.com/java-native-access/jna/blob/master/CHANGES.md
java-native-access/jna#1238
https://www.testcontainers.org/
@labels-and-badges labels-and-badges bot added NO JIRA This PR does not have a Jira Ticket PR:size/XS Denotes a Pull Request that changes 0-9 lines. labels Jan 19, 2024
Copy link

coderabbitai bot commented Jan 19, 2024

Important

Auto Review Skipped

Review was skipped due to path filters

Files ignored due to path filters (1)
  • pom.xml is excluded by: !**/*.xml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Jan 19, 2024
Copy link

sweep-ai bot commented Jan 19, 2024

Sweeping

Fixing PR: track the progress here.

I'm currently fixing this PR to address the following:

[Sweep GHA Fix] The GitHub Actions run failed with the following error logs:



[!CAUTION]

An error has occurred: Message is too long, max tokens is -6704 (tracking ID: c802b9ab3a)

@2lambda123 2lambda123 merged commit bd510ed into master Jan 19, 2024
4 of 5 checks passed
@trafico-bot trafico-bot bot added the ✨ Merged Pull Request has been merged successfully label Jan 19, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Enhancement

PR Summary: The pull request upgrades the JNA library to the latest version to ensure compatibility with Apple Mac M1 when running gigaspaces tests using testcontainers.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
  • Unsupported files: the diff contains files that Sourcery does not currently support during reviews.

General suggestions:

  • Ensure that the upgrade does not introduce any breaking changes or incompatibilities with existing code that relies on JNA.
  • Verify that all tests pass on multiple platforms, including the Apple Mac M1, to confirm that the upgrade has not introduced any regressions.
  • Consider adding a brief note in the documentation or change log to inform users about the upgrade and any potential impacts on their current setups.

Your trial expires on February 1, 2024. Please email tim@sourcery.ai to continue using Sourcery ✨


Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@trafico-bot trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet and removed 🔍 Ready for Review Pull Request is not reviewed yet ✨ Merged Pull Request has been merged successfully labels Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NO JIRA This PR does not have a Jira Ticket PR:size/XS Denotes a Pull Request that changes 0-9 lines. 🔍 Ready for Review Pull Request is not reviewed yet size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants