Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore default docker build #33

Merged
merged 3 commits into from
Mar 26, 2021
Merged

Conversation

DerekCrannaford
Copy link
Contributor

local run of 'staging' for default environment,
recreated and allowed for under !.gitignore
= restores ability to run docker-compose locally
without first installing any language support (no PHP nor PY)

refs:
issues: missing functionality of 7.4 release

Checklist

  • [Y] I'm using the correct PHP Version (7.4! for current, 7.0 for legacy).
  • [Y ] Tests are passing - manual observation of Docker-compose-up
  • [na ] I've added comments to any new methods I've created or where else relevant.
  • [ na] I've replaced magic method usage on DbService classes with the getInstance() static method.

Restore ability to run docker-compose locally

default environment, recreated and allowed for under !.gitignore

refs:
issues: missing functionality of 7.4 release

Other Information

local run of 'staging' for default environment,
recreated and allowed for under !.gitignore
= restores ability to run docker-compose locally
without first installing any language support (no PHP nor PY)

refs:
issues:  missing functionality of 7.4 release
twje added 2 commits March 26, 2021 02:24
By default it would of installed an incompatible version of xdebug
The default stage dir is the only stage dir to be checked into source
control.
@twje twje merged commit 417b609 into master Mar 26, 2021
@strongishllama strongishllama deleted the hotfix/restoreDefaultDockerBuild branch March 26, 2021 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants