fix: Stop core default as MASTER when no PHPversion #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerekCrannaford
added a commit
that referenced
this pull request
May 17, 2023
* Feature: work to codeception5 (#66) (#68) * First cut working, some kludges * First cut regressions for use * DB config for local * Incremental regressions into CodeSpaces * Correct testrunner config * No subsystem * Abandon auto chmod * As running in space * Check remote can push * GitIgnore UnitTest cache * Check can push from remote * Check can push from remote * Try to fix xdebug * Tentative XDebug OK * Retested Xdebug setup * Try DBug without restart * Still tweaking XDB * Still nudging XDB * Still A/B testing XDB settings * Update CI SeleniumRefs & Lint Docker Compose * Radically simplify XDebug ini * smtp config in template * Additional test env config on mail * Refactor per 8.1 ambitions * Skip questionable linter compatibility * Try alternative linter * Try 8.1 version overtrue * Use checkout v3 --------- Co-authored-by: Derek Crannaford <derek@2pisoftware.com> Co-authored-by: Adam Buckley <adam.buckley90@gmail.com> * Stop core default as MASTER when no PHPversion (#69) --------- Co-authored-by: Adam Buckley <adam.buckley90@gmail.com> Co-authored-by: Derek Crannaford <derek@2pisoftware.com>
DerekCrannaford
added a commit
that referenced
this pull request
Nov 16, 2023
* Feature: work to codeception5 (#66) (#68) * First cut working, some kludges * First cut regressions for use * DB config for local * Incremental regressions into CodeSpaces * Correct testrunner config * No subsystem * Abandon auto chmod * As running in space * Check remote can push * GitIgnore UnitTest cache * Check can push from remote * Check can push from remote * Try to fix xdebug * Tentative XDebug OK * Retested Xdebug setup * Try DBug without restart * Still tweaking XDB * Still nudging XDB * Still A/B testing XDB settings * Update CI SeleniumRefs & Lint Docker Compose * Radically simplify XDebug ini * smtp config in template * Additional test env config on mail * Refactor per 8.1 ambitions * Skip questionable linter compatibility * Try alternative linter * Try 8.1 version overtrue * Use checkout v3 --------- Co-authored-by: Derek Crannaford <derek@2pisoftware.com> Co-authored-by: Adam Buckley <adam.buckley90@gmail.com> * Stop core default as MASTER when no PHPversion (#69) * Allow test nav helper to be re-entrant --------- Co-authored-by: Adam Buckley <adam.buckley90@gmail.com> Co-authored-by: Derek Crannaford <derek@2pisoftware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmfive.php to support explicit legacy 7.0 & 7.4 OR no version = 8.1 with named branch