2주차 기본,도전,심화과제 PR #19

meenyweeny · 2022-04-22T12:43:12Z

🌱 작업한 내용

기본, 도전, 심화 과제를 했습니다..

🌱 PR Point

칭찬 부탁><

스크린샷 귀찮아서 죄송합니다

📸 스크린샷

구현 내용	스크린샷
ex. 로그인 화면	파일첨부바람

📮 관련 이슈

Resolved: [FEAT] iOS 2차 과제 #18

pcsoyeon

KIYA 역시 경민님 👍🏻 코드 깔끔하네요 !! 😎

pcsoyeon · 2022-04-22T21:25:15Z

assignment/assignment/Configuration/AppExtension/UIViewController+.swift

+
+extension UIViewController {
+    func changeRootViewController(_ viewControllerToPresent: UIViewController) {
+        if let window = UIApplication.shared.windows.first {


UIApplication.shared.windows. 요거 iOS 15에서도 가능한가여 ?? (just 궁금)

저도 궁금합니다!!

pcsoyeon · 2022-04-22T21:26:14Z

assignment/assignment/Scene/Join/JoinNameViewController.swift

@@ -58,7 +58,7 @@ final class JoinNameViewController: UIViewController {
    }

    @IBAction func nextButtonDidTap(_ sender: Any) {
-        guard let passwordVC = self.storyboard?.instantiateViewController(withIdentifier: "JoinPasswordViewController") as? JoinPasswordViewController else { return }
+        guard let passwordVC = self.storyboard?.instantiateViewController(withIdentifier: Const.ViewController.JoinPasswordVC) as? JoinPasswordViewController else { return }


상수 처리 한 것 너무 좋네요 😎

뷰 컨트롤러의 identifier를 따로 상수처리하는 이유가 뭔가요?? 찾아볼 때 조금더 효율적이라 따로 정리해두는 건가요??🧐
저도 배워서 사용해보고 싶어요!!!

pcsoyeon · 2022-04-22T21:27:43Z

assignment/assignment/Scene/MainTabbarController.swift

+        var borderView = UIView(frame: CGRect(x: 0, y: 0,
+                                              width: UIScreen.main.bounds.width, height: 1.5))
+        borderView.backgroundColor = UIColor(red: 218.0/255.0, green: 218.0/255.0, blue: 218.0/255.0, alpha: 1.0)
+        self.tabBar.addSubview(borderView)


요 borderView는 탭 바의 테두리(?)인가요 ??

pcsoyeon · 2022-04-22T21:28:13Z

assignment/assignment/Scene/MainTabbarController.swift

+    override func tabBar(_ tabBar: UITabBar, didSelect item: UITabBarItem) {
+        tabBar.backgroundColor = item.tag == 3 ? .black : .white
+        tabBar.tintColor = item.tag == 3 ? .white : .black
+        tabBar.barTintColor = item.tag == 3 ? .white : .black
+    }


오 이렇게 분기처리 할 수 있겠군요 !! 새로운 방법 알아갑니다 ~

와 이런코드 너무 신기하고 똑똑해요 ... 세상에 ... 🙉

저도 알아갑니다~~

tag를 통한 방법이 이거였군요 배워갑니다!!

yujindonut

경민...코드와 ... 폴더링 ... 다음주에 쑉쌱해서 와도 될까요... 정말 많이 배워갑니다...
과제 고생 너무 많았습니다!!!~ 😚😚

yujindonut · 2022-04-24T15:39:16Z

assignment/assignment/Scene/Login/LoginViewController.swift

        passwordTextField.isSecureTextEntry.toggle()
    }

    @IBAction func completeButtonDidTap(_ sender: Any) {
-        guard let completeVC = UIStoryboard(name: "Complete", bundle: nil).instantiateViewController(withIdentifier: "CompleteViewController") as? CompleteViewController else { return }
+        guard let completeVC = UIStoryboard(name: Const.Storyboard.Complete, bundle: nil).instantiateViewController(withIdentifier: Const.ViewController.CompleteVC) as? CompleteViewController else { return }


이렇게 Const.Storyboard를 사용하는 이유는 뭔가요...?!?!?(태클X...진짜단순궁금...)

yujindonut · 2022-04-24T15:40:00Z

assignment/assignment/Scene/MainTabbarController.swift

+    override func tabBar(_ tabBar: UITabBar, didSelect item: UITabBarItem) {
+        tabBar.backgroundColor = item.tag == 3 ? .black : .white
+        tabBar.tintColor = item.tag == 3 ? .white : .black
+        tabBar.barTintColor = item.tag == 3 ? .white : .black
+    }


와 이런코드 너무 신기하고 똑똑해요 ... 세상에 ... 🙉

88yhtserof

저도 상수 처리..? 공부해서 다음에 적용해볼래요🔥
그리고 Label 일부 단어 속성 변경하는 법 배워갑니다!!

88yhtserof · 2022-04-24T16:31:48Z

assignment/assignment/Configuration/AppExtension/UILabel+.swift

+    func setPartialLabelColor(targetStringList: [String], color: UIColor?) {
+        let fullText = text ?? ""
+        let attributedString = NSMutableAttributedString(string: fullText)
+        targetStringList.forEach {


targetStringList.forEach문이
fullText 중 targetString 원소에 해당하는 단어들만 속성을 바꿔주는 내용 맞나요?
제대로 이해했는지 궁금해요!!!

88yhtserof · 2022-04-24T16:35:55Z

assignment/assignment/Configuration/AppExtension/UIViewController+.swift

+
+extension UIViewController {
+    func changeRootViewController(_ viewControllerToPresent: UIViewController) {
+        if let window = UIApplication.shared.windows.first {


저도 궁금합니다!!

88yhtserof · 2022-04-24T16:46:31Z

assignment/assignment/Configuration/Const/ViewController.swift

@@ -23,13 +23,23 @@ extension Const {

        // MARK: - Home

+        static let HomeVC = "HomeViewController"


Const에 대해 설명해줄 수 있나요..😂
검색해보니깐 Constant, 상수를 정리할 때 사용하는 것 같은데,, 잘 모르겠어요,,
뷰 컨트롤러 구조체를 만드는데 주로 사용하는 걸까요??

88yhtserof · 2022-04-24T16:47:59Z

assignment/assignment/Scene/Join/JoinNameViewController.swift

@@ -58,7 +58,7 @@ final class JoinNameViewController: UIViewController {
    }

    @IBAction func nextButtonDidTap(_ sender: Any) {
-        guard let passwordVC = self.storyboard?.instantiateViewController(withIdentifier: "JoinPasswordViewController") as? JoinPasswordViewController else { return }
+        guard let passwordVC = self.storyboard?.instantiateViewController(withIdentifier: Const.ViewController.JoinPasswordVC) as? JoinPasswordViewController else { return }


뷰 컨트롤러의 identifier를 따로 상수처리하는 이유가 뭔가요?? 찾아볼 때 조금더 효율적이라 따로 정리해두는 건가요??🧐
저도 배워서 사용해보고 싶어요!!!

inuinseoul

잘보고갑니다!
항상 많이 배워요

inuinseoul · 2022-04-25T00:54:42Z

assignment/assignment/Configuration/AppExtension/UILabel+.swift

+    ///Label의 일부만 색을 바꿀 수 있는 익스텐션
+    func setPartialLabelColor(targetStringList: [String], color: UIColor?) {


이런 기능 필요할때가 종종있는데, extension으로 빼놓은거 좋네요

inuinseoul · 2022-04-25T00:56:45Z

assignment/assignment/Scene/MainTabbarController.swift

+    override func tabBar(_ tabBar: UITabBar, didSelect item: UITabBarItem) {
+        tabBar.backgroundColor = item.tag == 3 ? .black : .white
+        tabBar.tintColor = item.tag == 3 ? .white : .black
+        tabBar.barTintColor = item.tag == 3 ? .white : .black
+    }


저도 알아갑니다~~

0lynny

코드 너무 잘보고 갑니다..! 쑉쌱할 부분이 보여서 얼른 가서 수정해야겠어요>< 너무 수고 많으셧습니당

0lynny · 2022-04-25T10:27:05Z

assignment/assignment/Scene/Complete/CompleteViewController.swift

-        welcomeLabel.text = "\(userName)님 Instagram에 오신 것을 환영합니다"
+        welcomeLabel.text = """
+        \(userName)님 Instagram에
+        오신 것을 환영합니다
+        """


수정 전 코드와 수정 후 코드의 차이가 궁금합니다..!

0lynny · 2022-04-25T10:28:07Z

assignment/assignment/Scene/MainTabbarController.swift

+    override func tabBar(_ tabBar: UITabBar, didSelect item: UITabBarItem) {
+        tabBar.backgroundColor = item.tag == 3 ? .black : .white
+        tabBar.tintColor = item.tag == 3 ? .white : .black
+        tabBar.barTintColor = item.tag == 3 ? .white : .black
+    }


너무 깔꼼해보여요 ! 쑉쌱하고 싶은 코드네요 ><

0lynny · 2022-04-25T10:31:38Z

assignment/assignment/Scene/Login/LoginViewController.swift

+    private func setLabelUI() {
+        joinLabel.setPartialLabelColor(targetStringList: ["가입하기"], color: UIColor.tintColor)
    }


와 이렇게 라벨색상을 바꾸는거 알아갑니다! 위에 코드보고 어디에 쓰이는지 궁금했었는데 여기서 쓰이는 거였군요!

meenyweeny added 6 commits April 15, 2022 14:46

[#18] set tabbar

68a4f8b

[#18] 2주차 기본과제(2) - 탭바 구성 완료

c705c15

[#18] asset, extension 추가

d4c8dbd

[#18] 2주차 기본과제(1) - auto layout

f4bcac2

[#18] 2주차 기본과제(3) - 화면전환 추가 완료

3c21b1e

[#18] 2주차 도전과제 - Tabbar color 변경

7f72749

meenyweeny added PR assignment meenyweeny labels Apr 22, 2022

meenyweeny self-assigned this Apr 22, 2022

pcsoyeon approved these changes Apr 22, 2022

View reviewed changes

meenyweeny requested review from inuinseoul, 0lynny, yujindonut and 88yhtserof April 23, 2022 06:32

yujindonut reviewed Apr 24, 2022

View reviewed changes

88yhtserof reviewed Apr 24, 2022

View reviewed changes

inuinseoul reviewed Apr 25, 2022

View reviewed changes

0lynny reviewed Apr 25, 2022

View reviewed changes

meenyweeny merged commit cf458fd into main Apr 29, 2022

meenyweeny deleted the feature/#18 branch April 29, 2022 02:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2주차 기본,도전,심화과제 PR #19

2주차 기본,도전,심화과제 PR #19

meenyweeny commented Apr 22, 2022 •

edited

Loading

pcsoyeon left a comment

pcsoyeon Apr 22, 2022

88yhtserof Apr 24, 2022

pcsoyeon Apr 22, 2022

88yhtserof Apr 24, 2022 •

edited

Loading

pcsoyeon Apr 22, 2022

pcsoyeon Apr 22, 2022

yujindonut Apr 24, 2022

inuinseoul Apr 25, 2022

ffalswo2 Apr 27, 2022

yujindonut left a comment

yujindonut Apr 24, 2022

yujindonut Apr 24, 2022

88yhtserof left a comment

88yhtserof Apr 24, 2022

88yhtserof Apr 24, 2022

88yhtserof Apr 24, 2022

88yhtserof Apr 24, 2022 •

edited

Loading

inuinseoul left a comment

inuinseoul Apr 25, 2022

inuinseoul Apr 25, 2022

0lynny left a comment

0lynny Apr 25, 2022

0lynny Apr 25, 2022

0lynny Apr 25, 2022

		@@ -23,13 +23,23 @@ extension Const {

		// MARK: - Home

		static let HomeVC = "HomeViewController"

		///Label의 일부만 색을 바꿀 수 있는 익스텐션
		func setPartialLabelColor(targetStringList: [String], color: UIColor?) {

2주차 기본,도전,심화과제 PR #19

2주차 기본,도전,심화과제 PR #19

Conversation

meenyweeny commented Apr 22, 2022 • edited Loading

🌱 작업한 내용

🌱 PR Point

📸 스크린샷

📮 관련 이슈

pcsoyeon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

88yhtserof Apr 24, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yujindonut left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

88yhtserof left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

88yhtserof Apr 24, 2022 • edited Loading

Choose a reason for hiding this comment

inuinseoul left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0lynny left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

meenyweeny commented Apr 22, 2022 •

edited

Loading

88yhtserof Apr 24, 2022 •

edited

Loading

88yhtserof Apr 24, 2022 •

edited

Loading