-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] iOS 4차 과제 #13
base: main
Are you sure you want to change the base?
[FEAT] iOS 4차 과제 #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4차 과제도 수고하셨어요!! 보충될 코드들도 기대할게요🤗
|
||
struct LoginResponse: Codable { | ||
let status: Int | ||
let success: Bool? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
성공, 실패 둘 다 success값이 전달되던데, 혹시 success 파라미터를 옵셔널로 선언한 이유가 따로 있나요??🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
음.. 그러게요? 이유는 딱히 없고 실수인거 같습니다ㅠ
이번과제도 실수 만땅이네요 🥲 지적 감사합니다!!
@@ -55,6 +55,8 @@ final class SignUpPasswordViewModel { | |||
signUpUseCase.signUpError | |||
.subscribe(onNext: { error in | |||
switch error { | |||
case .alreadyExist: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
에러를 따로 처리하셨군요!! 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
보충된 과제가 벌써 기대가 되네요!!!!!🔥
정말 잘하시네요 !!!!! 고생하셨습니다 인우님!!!!
@@ -11,28 +11,46 @@ import RxRelay | |||
enum LoginError: Error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이렇게 케이스마다 에러를 보기쉽게 나눌수도 있군요!!!!😮
.map { URL(string: $0)! } | ||
.map { | ||
var request = URLRequest(url: $0) | ||
request.httpMethod = "POST" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rx .. 멋있습니다 ..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저도 아직 어렵지만... 열심히해보고 있슴당..
🌱 작업한 내용
🌱 PR Point
📸 스크린샷
📮 관련 이슈