[FEAT] iOS 4차 과제 #13
Open
[FEAT] iOS 4차 과제 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inuinseoul
requested review from
pcsoyeon,
88yhtserof,
meenyweeny,
0lynny and
yujindonut
88yhtserof
reviewed
May 16, 2022
|
|
||
| struct LoginResponse: Codable { | ||
| let status: Int | ||
| let success: Bool? |
There was a problem hiding this comment.
성공, 실패 둘 다 success값이 전달되던데, 혹시 success 파라미터를 옵셔널로 선언한 이유가 따로 있나요??🤔
There was a problem hiding this comment.
음.. 그러게요? 이유는 딱히 없고 실수인거 같습니다ㅠ
이번과제도 실수 만땅이네요 🥲 지적 감사합니다!!
| @@ -55,6 +55,8 @@ final class SignUpPasswordViewModel { | |||
| signUpUseCase.signUpError | |||
| .subscribe(onNext: { error in | |||
| switch error { | |||
| case .alreadyExist: | |||
yujindonut
reviewed
May 16, 2022
| @@ -11,28 +11,46 @@ import RxRelay | |||
| enum LoginError: Error { | |||
There was a problem hiding this comment.
이렇게 케이스마다 에러를 보기쉽게 나눌수도 있군요!!!!😮
| .map { URL(string: $0)! } | ||
| .map { | ||
| var request = URLRequest(url: $0) | ||
| request.httpMethod = "POST" |
There was a problem hiding this comment.
저도 아직 어렵지만... 열심히해보고 있슴당..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 작업한 내용
🌱 PR Point
📸 스크린샷
📮 관련 이슈