Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when get a property of a node #42

Closed
MadFlyFish opened this issue May 9, 2022 · 7 comments
Closed

Error when get a property of a node #42

MadFlyFish opened this issue May 9, 2022 · 7 comments

Comments

@MadFlyFish
Copy link

MadFlyFish commented May 9, 2022

image

image

image

image

@MadFlyFish
Copy link
Author

It seems that it is treated as a resource rather than a node

@31
Copy link
Owner

31 commented May 9, 2022

Hmm. I probably broke this with some recent changes to accommodate some unusual situations. You could try 1.1.6 until I can fix it.

@MadFlyFish
Copy link
Author

Well, 1.1.6 works fine on this issue. Thanks.
And by the way, I think OnReadyFind is unnecessary, because godot 3.5 beta5 has Implemented the function of scene unique nodes ,which is more reasonable.
godotengine/godot#60527
image

@31
Copy link
Owner

31 commented May 10, 2022

Once "scene unique nodes" (which does looks nice) is in a stable release, it does seem to overlap what OnReadyFind can do, although not quite all. It would also require changing code to start using it, and I don't see the reason to force people to do that by removing OnReadyFind.

I'm just waiting to see if GodotOnReady is necessary in 4.0 and either rewrite to fit or drop it entirely. 😄 GodotOnReady as a whole should be obsolete in 4.0, since this issue's milestone is set:

@MadFlyFish
Copy link
Author

Thanks for the details.
I think 4.0 stable will face a long wait and I will stick to 3.x in my case.
GodotOnReady is still a great addition to 3.x and keeps code clean.

@31
Copy link
Owner

31 commented May 10, 2022

I've fixed this up and released GodotOnReady 1.2.1. (But, OnReadyFind is the only thing that's been added since 1.1.6, so no need to upgrade if you aren't planning on using it. 😄.)

Thanks for noticing and filing the issue!

@31 31 closed this as completed May 10, 2022
@MadFlyFish
Copy link
Author

1.2.1 works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants