Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Property -> GetNode implication back in to fix [OnReadyGet("AnimationTree", Property = "parameters/playback")] #43

Merged
merged 1 commit into from
May 10, 2022

Conversation

31
Copy link
Owner

@31 31 commented May 10, 2022

I removed the site.AttributeSite.Attribute.NamedArguments.Any(a => a.Key == "Property" && a.Value.Value is string { Length: > 0 }) check while working on this PR:

This causes the example in the readme (getting the animation state) not to work:

This PR adds the condition back in, and adds Property usage into the dev project so it'll be harder to overlook again. 🙂

(I think that really, I should have had [OnReadyGet] and [OnReadyLoad] separated from the beginning. I don't think it's really all that useful to use the same attribute name for both Nodes and Resources. If you're switching a field/property from Node to a Resource, that's a big change--surely it's ok to change this, too. The library can even generate a very specific, clear compile error to make it easy.)

@31 31 merged commit 77bbaaa into main May 10, 2022
@31 31 deleted the dev/31/fix-prop-always-node branch May 10, 2022 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant