Add the Property -> GetNode implication back in to fix [OnReadyGet("AnimationTree", Property = "parameters/playback")]
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the
site.AttributeSite.Attribute.NamedArguments.Any(a => a.Key == "Property" && a.Value.Value is string { Length: > 0 })check while working on this PR:This causes the example in the readme (getting the animation state) not to work:
This PR adds the condition back in, and adds
Propertyusage into the dev project so it'll be harder to overlook again. 🙂(I think that really, I should have had
[OnReadyGet]and[OnReadyLoad]separated from the beginning. I don't think it's really all that useful to use the same attribute name for both Nodes and Resources. If you're switching a field/property from Node to a Resource, that's a big change--surely it's ok to change this, too. The library can even generate a very specific, clear compile error to make it easy.)