-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the SDL documentation #483
Conversation
I think we should be consistent about the SDL versions we're recommending/automagically installing... WSL/MinGW docs also specify 2.0.10 and the various CI scripts install that. Auto-install in |
I can update the other references as well and add them to this PR. |
All places now refer to 2.0.14
Changed every place to be the same version 2.0.14, docs, scripts, everything :) |
Thanks for giving the docs a shakeup and trying to get the SDL setup consistent. It's appreciated! Judging by the test failures on MinGW I think you also need to update - https://github.com/pimoroni/32blit-beta/blob/master/ci/install_sdl_mingw.sh |
I actually did update that file, and now I am trying to figure out the error logs, why it failed here on Github? Strange. |
There is something nasty going on with SDL's CMake config in the MinGW build... The library path is very wrong... Partly caused by this: https://github.com/pimoroni/32blit-beta/blob/master/mingw.toolchain#L4-L5 (library name ends up |
Okay at least some of it is bugs in SDL's CMake config... (not setting Even fixing that and some stuff on the blit side, it still fails because |
I think this needs rebased to see if it builds with the latest fixes? |
Looks like SDL has fixed the MinGW problem: libsdl-org/SDL@501fe46... |
Yep, 2.0.16 works: master...Daft-Freak:lenardg/docs/sdl |
Replaced by #783 - thank you all! |
Updated the SDL version number in the docs for Visual Studio.
Also, added a bulleted list - on a quick read it was not immediately obvious there are two libraries to get.