Fix exit(0) crashing #760
Merged
Fix exit(0) crashing #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can't have exit returning when it's marked noreturn
|
Ooh, nice, thank you! The magic fix looks intriguing though if my experience at being terrible at writing drivers for MicroPython is anything to go by, it can't hurt to have a real system reset every now and then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exitis marked as not returning, bad things happen if it does. This worked fine until #661 made it so thatblit_exitdidn't reset when there wasn't an error.This is the easiest fix of always resetting in
blit_exit... which isn't as clean an exit as you get from using the menu. While typing this patch I thought of an alternative, which is slightly more magic: Daft-Freak@645a3a5