Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid DMA channel/PIO SM conflicts from scanvideo/audio #801

Merged
merged 4 commits into from
May 17, 2023

Conversation

Daft-Freak
Copy link
Collaborator

This is a bit of a hack due to pico-extras not using *_claim_unused_* (scanvideo using hardcoded numbers). Avoids more hardcoding/hacks in the SD card and DVI code.

@Daft-Freak
Copy link
Collaborator Author

This might get less nasty, depending on what happens with the pico-extras PR I just opened...

@Gadgetoid Gadgetoid merged commit f3333f8 into 32blit:master May 17, 2023
@Gadgetoid
Copy link
Contributor

IMO Pico Extras looks... neglected? I'm tempted to just vendor the i2s driver and fix it downstream until we get something that's not in i2s purgatory.

Not that we should rush to reinvent the wheel, but I'm pretty sure I've had use cases where all the buffer pool handling is just unnecessary bloat. This might even be one of those cases- IIRC the STM32 32blit port just uses a single buffer with a half complete callback.

@Daft-Freak Daft-Freak deleted the pico-extras-dma-sm-alloc branch May 17, 2023 12:54
@Daft-Freak
Copy link
Collaborator Author

Yeah, could definitely write a simplified i2s driver (and save some RAM). Same probably applies for scanvideo, we're not using half the features and the thing we do need (mode switching, or at least the scale) isn't implemented... Guess that's another thing to look at at some point.

The STM32 port... doesn't even have a buffer... (#568)

@Gadgetoid
Copy link
Contributor

The STM32 port... doesn't even have a buffer... (#568)

ಠ_ಠ

I had forgotten this little factoid 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants