Minor nitpicking

[Daft-Freak]

The main thing here is that the PicoSystem stuff referred to the RP2040's bootloader as "DFU" which it isn't. But also I "corrected" "MacOS" to "macOS" because it's weird like that.

[Gadgetoid]

But also I "corrected" "MacOS" to "macOS" because it's weird like that.

Hahaha, this also bugs me everywhere I see it 😆

[Daft-Freak]

Haven't done anything about this one, but "We're relying on converting to integers to truncate and hence round down"... "since it will round up (rather than down) if the value is negative" Sooo, it's relying on rounding towards zero.

(Guess which language doesn't have a built-in function to do that...)

[Daft-Freak]

Just dumping a bunch of comments here...

C++ code is using uint8_t for loop indices and I know from reading too much disassembly that that just adds a bunch of UXTB instructions. (or, it's making the code less efficient for no reason, also possibly applies to some of the args and temps as well).

Don't like the use of both pressed (the function) and buttons.pressed. (Or generally the fact that "pressed" means two things, but I entirely forgot that the function existed)

EDIT: std::srand(std::time(0)); isn't going to be very useful without a current time to return...

[Gadgetoid]

C++ code is using uint8_t for loop indices and I know from reading too much disassembly that that just adds a bunch of UXTB instructions. (or, it's making the code less efficient for no reason, also possibly applies to some of the args and temps as well).

Wow. TIL!

It's usually my preference to use auto i = 0u, though I have no idea what that actually results in.