Merge pull request #35 from 33Across/video_size_fix

fix for sizes + valid sample GUID
33Across · Nov 4, 2020 · 3bcbced · 3bcbced
2 parents 7fedd5a + f3ab865
commit 3bcbced
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 8 deletions.
diff --git a/modules/33acrossBidAdapter.js b/modules/33acrossBidAdapter.js
@@ -337,8 +337,7 @@ function _buildVideoORTB(bidRequest) {
 
   const video = {}
 
-  const sizes = videoAdUnit.playerSize || [];
-  const {w, h} = _getSize(sizes);
+  const {w, h} = _getSize(videoParams.playerSize[0]);
   video.w = w;
   video.h = h;
 

diff --git a/modules/33acrossBidAdapter.md b/modules/33acrossBidAdapter.md
@@ -29,8 +29,8 @@ var adUnits = [
   bids: [{
     bidder: '33across',
     params: {
-        siteId: 'sampleGUID123',     
-        productId: 'siab|inview'     
+        siteId: 'sample33xGUID123456789',     
+        productId: 'siab'     
     }
   }]
 }
@@ -73,7 +73,7 @@ var adUnits = [
   bids: [{
     bidder: '33across',
     params: {
-        siteId: 'sampleGUID123',     
+        siteId: 'sample33xGUID123456789',     
         productId: 'siab'     
     }
   }]
@@ -123,7 +123,7 @@ var adUnits = [
   bids: [{
     bidder: '33across',
     params: {
-        siteId: 'sampleGUID123',     
+        siteId: 'sample33xGUID123456789',     
         productId: 'siab'     
     }
   }]
@@ -146,7 +146,7 @@ var adUnits = [
   bids: [{
     bidder: '33across',
     params: {
-        siteId: 'sampleGUID123',     
+        siteId: 'sample33xGUID123456789',     
         productId: 'instream'     
     }
   }]

diff --git a/test/spec/modules/33acrossBidAdapter_spec.js b/test/spec/modules/33acrossBidAdapter_spec.js
@@ -262,7 +262,7 @@ describe('33acrossBidAdapter:', function () {
 
     this.withVideo = (params) => {
       bidRequests[0].mediaTypes.video = {
-        playerSize: [300, 250],
+        playerSize: [[300, 250]],
         context: 'outstream',
         ...params
       };