-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle multi imp requests #2
Conversation
@@ -104,36 +110,35 @@ func preprocess(request *openrtb.BidRequest) error { | |||
impExt.Ttx.Prod = ttxExt.ProductId | |||
|
|||
// Add zoneid if it's defined | |||
impExt.Ttx.Zoneid = ttxExt.SiteId |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that we will no longer be setting GUID under site.id
, will use zoneID. This is to ensure that we can pass requests from app
to TTX as well. TTX can decide independently how to handle this scenario,
adapters/33across/33across.go
Outdated
|
||
if impCopy.Banner == nil && impCopy.Video == nil { | ||
return openrtb.Imp{}, &errortypes.BadInput{ | ||
Message: fmt.Sprintf("Imp ID %s must have at one of [Banner, Video] defined", impCopy.ID), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo "at least one"
do you mention this PR also includes the caller changes |
No description provided.