Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI - dsconf inst config should support multi-valued operations #5798

Closed
droideck opened this issue Jun 14, 2023 · 2 comments · Fixed by #5799 or #6426
Closed

CLI - dsconf inst config should support multi-valued operations #5798

droideck opened this issue Jun 14, 2023 · 2 comments · Fixed by #5799 or #6426
Assignees
@droideck
Labels
CLI CLI tools needs triage The issue will be triaged during scrum

Comments

@droideck
Copy link
Member

droideck commented Jun 14, 2023 •
edited
Loading

Issue Description
We have two editable multi-valued attributes in cn=config: nsslapd-haproxy-trusted-ip and nsslapd-referral.

Our current cn=config implementation doesn't support bunch ADD operations.
And while it'll be too much work to refactor our cn=config (and I'm not sure we need that at all), we still should
make our CLI tools more robust so it can handle multi-valued attributes correctly.
@droideck droideck added CLI CLI tools needs triage The issue will be triaged during scrum labels Jun 14, 2023
@droideck droideck self-assigned this Jun 14, 2023
droideck added a commit to droideck/389-ds-base that referenced this issue Jun 14, 2023
@droideck
Issue 5798 - CLI - Add multi-valued sopport to dsconf config
c5dea0b 
Description: Currently, we have two editable multi-valued attributes in cn=config:
nsslapd-haproxy-trusted-ip and nsslapd-referral.

Our current cn=config implementation doesn't support bunch ADD operations.
Make our CLI tools more robust so it can handle multi-valued attributes correctly.

Add add_many method to DSLdapObject.

Fixes: 389ds#5798

Reviewed by: ?
@droideck droideck mentioned this issue Jun 14, 2023
Merged
droideck added a commit that referenced this issue Jun 16, 2023
@droideck
Issue 5798 - CLI - Add multi-valued support to dsconf config (#5799)
3cdc7d8 
Description: Currently, we have two editable multi-valued attributes in cn=config:
nsslapd-haproxy-trusted-ip and nsslapd-referral.

Our current cn=config implementation doesn't support bunch ADD operations.
Make our CLI tools more robust so they can handle multi-valued attributes correctly.

Add add_many method to DSLdapObject.

Fixes: #5798

Reviewed by: @mreynolds389 (Thanks!)
droideck added a commit that referenced this issue Jan 15, 2024
@droideck
Issue 5798 - CLI - Add multi-valued support to dsconf config (#5799)
c3fbd49 
Description: Currently, we have two editable multi-valued attributes in cn=config:
nsslapd-haproxy-trusted-ip and nsslapd-referral.

Our current cn=config implementation doesn't support bunch ADD operations.
Make our CLI tools more robust so they can handle multi-valued attributes correctly.

Add add_many method to DSLdapObject.

Fixes: #5798

Reviewed by: @mreynolds389 (Thanks!)
@droideck droideck reopened this Nov 29, 2024
@droideck
Copy link
Member Author

There are two more issues that needs to be fixed/enhanced:

  • After a restart, some values of the configuration parameter nsslapd-haproxy-trusted-ip are gone - add operation is not handled correctly.

  • It would be useful if the "dsconf config replace" command can be used to replace current value(s) with new ones.
    For instance, to replace the existing values of "nsslapd-haproxy-trusted-ip":

    dsconf -D "cn=Directory Manager" ldap://<HOST>:<PORT> config replace nsslapd-haproxy-trusted-ip=<NEW_IP_ADDRESS_1> nsslapd-haproxy-trusted-ip=<NEW_IP_ADDRESS_2> nsslapd-haproxy-trusted-ip=<NEW_IP_ADDRESS_3>

droideck added a commit to droideck/389-ds-base that referenced this issue Nov 29, 2024
@droideck
Issue 5798 - Fix dsconf config multi-valued attr operations
f061193 
Description:
Fix add operation to properly handle multi-valued attributes
so they persist after server restart.
Add support for multiple values at once via dsconf config.
Handle delete operation in a more flexible way.
Refactor attribute handling code for better error handling and consistency.

Fixes: 389ds#5798

Reviewed by: ?
droideck added a commit to droideck/389-ds-base that referenced this issue Nov 29, 2024
@droideck
Issue 5798 - Fix dsconf config multi-valued attr operations
2b2e8c2 
Description:
Fix add operation to properly handle multi-valued attributes
so they persist after server restart.
Add support for multiple values at once via dsconf config.
Handle delete operation in a more flexible way.
Refactor attribute handling code for better error handling and consistency.

Fixes: 389ds#5798

Reviewed by: ?
@droideck droideck mentioned this issue Nov 29, 2024
Merged
droideck added a commit that referenced this issue Dec 5, 2024
@droideck
Issue 5798 - Fix dsconf config multi-valued attr operations (#6426)
3398e73 
Description:
Fix add operation to properly handle multi-valued attributes
so they persist after server restart.
Add support for multiple values at once via dsconf config.
Handle delete operation in a more flexible way.
Refactor attribute handling code for better error handling and consistency.
*Add CI test suite

Fixes: #5798

Reviewed by: @progier389 (Thanks!)
droideck added a commit that referenced this issue Dec 5, 2024
@droideck
Issue 5798 - Fix dsconf config multi-valued attr operations (#6426)
4c8bb4e 
Description:
Fix add operation to properly handle multi-valued attributes
so they persist after server restart.
Add support for multiple values at once via dsconf config.
Handle delete operation in a more flexible way.
Refactor attribute handling code for better error handling and consistency.
*Add CI test suite

Fixes: #5798

Reviewed by: @progier389 (Thanks!)
droideck added a commit that referenced this issue Dec 5, 2024
@droideck
Issue 5798 - Fix dsconf config multi-valued attr operations (#6426)
cdfdeed 
Description:
Fix add operation to properly handle multi-valued attributes
so they persist after server restart.
Add support for multiple values at once via dsconf config.
Handle delete operation in a more flexible way.
Refactor attribute handling code for better error handling and consistency.
*Add CI test suite

Fixes: #5798

Reviewed by: @progier389 (Thanks!)
droideck added a commit that referenced this issue Dec 5, 2024
@droideck
Issue 5798 - Fix dsconf config multi-valued attr operations (#6426)
d90fd28 
Description:
Fix add operation to properly handle multi-valued attributes
so they persist after server restart.
Add support for multiple values at once via dsconf config.
Handle delete operation in a more flexible way.
Refactor attribute handling code for better error handling and consistency.
*Add CI test suite

Fixes: #5798

Reviewed by: @progier389 (Thanks!)
@droideck
Copy link
Member Author

droideck commented Dec 5, 2024

97a82e5..4c8bb4e 389-ds-base-3.0 -> 389-ds-base-3.0
adba69d..cdfdeed 389-ds-base-2.5 -> 389-ds-base-2.5
1b4b6b5..d90fd28 389-ds-base-2.4 -> 389-ds-base-2.4

@mmatsuya mmatsuya mentioned this issue Jan 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@droideck droideck

Labels
CLI CLI tools needs triage The issue will be triaged during scrum
Projects
None yet
Milestone
No milestone
1 participant
@droideck