Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pblock access from switch to func table #6574

Open
mreynolds389 opened this issue Feb 3, 2025 · 0 comments
Open

Move pblock access from switch to func table #6574

mreynolds389 opened this issue Feb 3, 2025 · 0 comments
Assignees
@mreynolds389
Labels
needs triage The issue will be triaged during scrum performance Issue impacts performance

Comments

@mreynolds389
Copy link
Contributor

Issue Description

Currently there are over 300 switch cases for getting/setting pblock parameters.

Instead we should have separate functions for each parameter, and a callback function pointer table.
@mreynolds389 mreynolds389 added needs triage The issue will be triaged during scrum performance Issue impacts performance labels Feb 3, 2025
@mreynolds389 mreynolds389 self-assigned this Feb 3, 2025
mreynolds389 added a commit to mreynolds389/389-ds-base that referenced this issue Feb 3, 2025
@mreynolds389
Issue 6574 - Move pblock access from switch to func table
e9c1749 
Description

Currently there are over 300 switch cases for getting/setting pblock parameters.

Instead we should have separate functions for each parameter, and a callback
function pointer table.

This also combines all the parameter definitions to a single ordered list. This
will make future changes much easier to implement.

Relates: 389ds#6574

Reviewed by: ?
mreynolds389 added a commit to mreynolds389/389-ds-base that referenced this issue Feb 3, 2025
@mreynolds389
Issue 6574 - Move pblock access from switch to func table
6aa2a04 
Description

Currently there are over 300 switch cases for getting/setting pblock parameters.

Instead we should have separate functions for each parameter, and a callback
function pointer table.

This also combines all the parameter definitions to a single ordered list. This
will make future changes much easier to implement.

Relates: 389ds#6574

Reviewed by: ?
mreynolds389 added a commit to mreynolds389/389-ds-base that referenced this issue Feb 3, 2025
@mreynolds389
Issue 6574 - Move pblock access from switch to func table
005db05 
Description

Currently there are over 300 switch cases for getting/setting pblock parameters.

Instead we should have separate functions for each parameter, and use a callback
function pointer table.

This also combines all the parameter definitions to a single ordered list. This
will make future changes much easier to implement.

Relates: 389ds#6574

Reviewed by: ?
@mreynolds389 mreynolds389 mentioned this issue Feb 3, 2025
Open
mreynolds389 added a commit to mreynolds389/389-ds-base that referenced this issue Feb 4, 2025
@mreynolds389
Issue 6574 - Move pblock access from switch to func table
1b70acc 
Description

Currently there are over 300 switch cases for getting/setting pblock parameters.

Instead we should have separate functions for each parameter, and use a callback
function pointer table.

Relates: 389ds#6574

Reviewed by: spichugi, firstyear, progier, tbordaz (Thnaks!!!!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mreynolds389 mreynolds389

Labels
needs triage The issue will be triaged during scrum performance Issue impacts performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mreynolds389