Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve LoD11 fallback/skip mechanism + timeout #94

Merged
merged 10 commits into from
Dec 5, 2024
Merged

Improve LoD11 fallback/skip mechanism + timeout #94

merged 10 commits into from
Dec 5, 2024

Conversation

Ylannl
Copy link
Member

@Ylannl Ylannl commented Dec 3, 2024

For the roofer CLI, fixes #74

  • skip plane detection if fallback initiated prior to reconstruct
  • implement timeout for plane detector
  • implement detected planes limit for plane detector
  • add respective configuration options lod11-fallback-time (in ms) and lod11-fallback-planes
  • add rf_extrusion_mode attribute (values can be: standard, fallback, skip)
  • rename rf_status to rf_success
  • compute attributes with lod1.1 extrusion
    • volume
    • val3dity
    • rmse
  • set some attributes to null when skipping or doing lod11 fallback
    • h_[min/max/90p]
    • n_planes
    • volume
    • val3dity
    • rmse
  • set sensible default values for lod11 fallback time and planes

@Ylannl Ylannl self-assigned this Dec 5, 2024
@Ylannl Ylannl changed the title Improve LoD11 fallback mechanism Improve LoD11 fallback mechanism + timeout Dec 5, 2024
@Ylannl Ylannl changed the title Improve LoD11 fallback mechanism + timeout Improve LoD11 fallback/skip mechanism + timeout Dec 5, 2024
@Ylannl Ylannl merged commit 86ff4bf into develop Dec 5, 2024
7 of 8 checks passed
@Ylannl Ylannl deleted the issue/74 branch December 5, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add timeout for reconstruction
1 participant