This repository has been archived by the owner on Jun 10, 2024. It is now read-only.
Issue#40 components updates #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for 3dstreet-editor-builds ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@omedvediev what is the definition of "done" here? Should everything just look and act exactly the same? Here is one thing that does not work the same that needs to be updated in order to merge. Note the Essential Actions and Keyboard Shortcut buttons no longer have correct styling: cc @ihordubas1 if you want to take this over |
|
reminder to @omedvediev and @ihordubas1 to address the remaining issue so we can merge before we make too many more changes on master |
|
@ihordubas1 this is the second highest priority ticket |
|
@ihordubas1 i will also need your help to resolve conflicts here before merging |
This was referenced Feb 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.