-
Notifications
You must be signed in to change notification settings - Fork 3
Issue#145 Add preview modal window for screenshots #191
Conversation
✅ Deploy Preview for 3dstreet-editor-builds ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@ihordubas1 thanks for this! On first glance it is great progress. I can share more feedback later today. |
Hi @ihordubas1 here is some feedback, let me know if any visuals are needed:
|
thanks for comments @kfarr |
thanks @ihordubas1 2 of the 3 issues were resolved, thank you! The remaining issues are placement and sizing of the screenshot on the preview window 2 issues:
|
@ihordubas1 another issue is the sizing of the dialog box The intent is that the dialog reflects the aspect ratio of the document window. For example, the dialog could be approx 80% of height and width of the viewport and the image within the dialog could be 70% of the height and width. (That's just an example, the exact numbers may be a bit different.) |
Ok I fixed the width and height of the dialog box with this commit 4b1c7f0 Next is to ensure that the image is placed and sized correctly. I notice that you are still using this sample code, this was intended as an example, not to literally use as is: For example, instead of positioning this way the img could be a child of the dialog box node and positioned using vw and vh such as 80vh 80vw Does that make sense? |
this looks great, thanks @rostyslavnahornyi |
#145